Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message parser being slow to process very long messages with too many symbols #33255

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: message parser being slow to process very long messages with too many symbols #33255

merged 1 commit into from
Sep 11, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 11, 2024

Backport of #33227

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 9f748a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/message-parser Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.11 milestone Sep 11, 2024
@dionisio-bot dionisio-bot
Copy link
Contributor Author

dionisio-bot bot commented Sep 11, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot removed the backport label Sep 11, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Sep 11, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.11.3@68740e1). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.11.3   #33255   +/-   ##
=================================================
  Coverage                  ?   58.40%           
=================================================
  Files                     ?     2637           
  Lines                     ?    57523           
  Branches                  ?    11940           
=================================================
  Hits                      ?    33597           
  Misses                    ?    22141           
  Partials                  ?     1785
Flag Coverage Δ
e2e 58.64% <ø> (?)
unit 74.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Sep 11, 2024
@kodiakhq kodiakhq bot merged commit f07a6cd into release-6.11.3 Sep 11, 2024
55 of 62 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.11.3-33227 branch September 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

Assignees

@scuciatto scuciatto

Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.11
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-lehnen-rc @scuciatto @julio-cfa